From: Reedy <reedy@wikimedia.org>
Date: Thu, 12 Jul 2012 00:09:37 +0000 (+0100)
Subject: Remove some unused variables
X-Git-Tag: 1.31.0-rc.0~23063^2
X-Git-Url: http://git.cyclocoop.org/%22.%24info%5B?a=commitdiff_plain;h=17fcd2aeda02933b74d5bd4fab2b5e72142dfbb6;p=lhc%2Fweb%2Fwiklou.git

Remove some unused variables

Add some comments

Add some braces

Change-Id: I84c050b6baf8ef8d21735c1ba56b7782b3c54855
---

diff --git a/includes/specials/SpecialListusers.php b/includes/specials/SpecialListusers.php
index 75be397fba..ebcca7313e 100644
--- a/includes/specials/SpecialListusers.php
+++ b/includes/specials/SpecialListusers.php
@@ -34,6 +34,10 @@
  */
 class UsersPager extends AlphabeticPager {
 
+	/**
+	 * @param $context IContextSource
+	 * @param $par null|array
+	 */
 	function __construct( IContextSource $context = null, $par = null ) {
 		if ( $context ) {
 			$this->setContext( $context );
@@ -69,10 +73,16 @@ class UsersPager extends AlphabeticPager {
 		parent::__construct();
 	}
 
+	/**
+	 * @return string
+	 */
 	function getIndexField() {
 		return $this->creationSort ? 'user_id' : 'user_name';
 	}
 
+	/**
+	 * @return Array
+	 */
 	function getQueryInfo() {
 		$dbr = wfGetDB( DB_SLAVE );
 		$conds = array();
@@ -125,18 +135,20 @@ class UsersPager extends AlphabeticPager {
 		return $query;
 	}
 
+	/**
+	 * @param $row Object
+	 * @return String
+	 */
 	function formatRow( $row ) {
-		if ($row->user_id == 0) #Bug 16487
+		if ( $row->user_id == 0 ) { #Bug 16487
 			return '';
+		}
 
 		$userName = $row->user_name;
 
 		$ulinks = Linker::userLink( $row->user_id, $userName );
 		$ulinks .= Linker::userToolLinks( $row->user_id, $userName );
 
-		$userPage = Title::makeTitle( NS_USER, $row->user_name );
-		$name = Linker::link( $userPage, htmlspecialchars( $userPage->getText() ) );
-
 		$lang = $this->getLanguage();
 
 		$groups_list = self::getGroups( $row->user_id );
@@ -186,9 +198,12 @@ class UsersPager extends AlphabeticPager {
 		$this->mResult->rewind();
 	}
 
+	/**
+	 * @return string
+	 */
 	function getPageHeader( ) {
 		global $wgScript;
-		// @todo Add a PrefixedBaseDBKey
+
 		list( $self ) = explode( '/', $this->getTitle()->getPrefixedDBkey() );
 
 		# Form tag
@@ -243,10 +258,12 @@ class UsersPager extends AlphabeticPager {
 	 */
 	function getDefaultQuery() {
 		$query = parent::getDefaultQuery();
-		if( $this->requestedGroup != '' )
+		if( $this->requestedGroup != '' ) {
 			$query['group'] = $this->requestedGroup;
-		if( $this->requestedUser != '' )
+		}
+		if( $this->requestedUser != '' ) {
 			$query['username'] = $this->requestedUser;
+		}
 		wfRunHooks( 'SpecialListusersDefaultQuery', array( $this, &$query ) );
 		return $query;
 	}